• Bug#1077783: pcmciautils: Incorrect component type in Appstream metainf

    From Petter Reinholdtsen@21:1/5 to All on Fri Aug 2 07:40:01 2024
    Package: pcmciautils
    Verion: 018-17
    Tags: patch

    The Appstream validation report the following problem with the metadata
    I submitted in BTS #1077051.

    Errors

    * gui-app-without-icon
    The component is a GUI application (application which has a .desktop
    file for the XDG menu and Type=Application), but we could not find a
    matching icon for this application.

    Warnings

    * asv-desktop-app-launchable-missing
    org.kernel.software.linux.pcmciautils.metainfo.xml -
    This `desktop-application` component is missing a `desktop-id`
    launchable tag. This means that this application can not be launched
    and has no association with its desktop-entry file. It also means no
    icon data or category information from the desktop-entry file will
    be available, which will result in this application being ignored
    entirely.

    * missing-launchable-desktop-file
    The MetaInfo file references a .desktop file with ID
    'org.kernel.software.linux.pcmciautils.desktop' in its launchable
    tag, but the file was not found in the same source tree. In order to
    be able to launch the software once it was installed, please place
    the MetaInfo file and its .desktop files in the same package.


    I am very sorry about this. These block the metadata from being
    included in the published database. The metadata got the incorrect
    component (cut-n-paste error on my part), and should look like this
    instead:

    diff --git a/debian/org.kernel.software.linux.pcmciautils.metainfo.xml b/debian/org.kernel.software.linux.pcmciautils.metainfo.xml
    index 7a999e5..44298dd 100644
    --- a/debian/org.kernel.software.linux.pcmciautils.metainfo.xml
    +++ b/debian/org.kernel.software.linux.pcmciautils.metainfo.xml
    @@ -1,5 +1,5 @@
    <?xml version="1.0" encoding="UTF-8"?>
    -<component type="desktop">
    +<component>
    <id>org.kernel.software.linux.pcmciautils</id>
    <metadata_license>MIT</metadata_license>
    <name>pcmciautils</name>

    With the correct type, the file validates:

    % appstreamcli validate-tree --no-net --explain debian/pcmciautils
    org.kernel.software.linux.pcmciautils.metainfo.xml
    I: org.kernel.software.linux.pcmciautils:~: developer-info-missing
    This component contains no `developer` element with information
    about its author.

    ? Validation was successful: infos: 1, pedantic: 1
    %

    --
    Happy hacking
    Petter Reinholdtsen

    --- SoupGate-Win32 v1.05
    * Origin: fsxNet Usenet Gateway (21:1/5)